-
Notifications
You must be signed in to change notification settings - Fork 3
Implement CI Pipeline for K* Planner MCP Server and Resolve Python Package Naming Conflict #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ctpelok77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 2 comments.
| @@ -0,0 +1,9 @@ | |||
| FROM python:3.11 | |||
|
|
|||
| RUN apt-get update && apt-get install -y cmake make g++ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need cmake and g++?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line was supposed to be checked at your pull request for using K* package binary. Did you check it?
|
|
||
| payload = await client.call_tool( | ||
| "KstarPlannerUnorderedTopQ", | ||
| {"domain": domain, "problem": problem}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should explicitly provide the important parameters here without depending on defaults not changing:
quality_bound: float = 1.0,
num_plans: int = 10
If the quality bound changes, there might be more than one plan returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is for establishing the CI pipeline for K* MCP Server nothing else.
Related Issue:
#23
This pull request implements a continuous integration pipeline for the KMCPServer project using GitHub Actions. The pipeline will:
This automation will help ensure code quality, catch regressions early, and streamline the release process.
To prevent potential naming conflicts with the Python map package, the
mcpfolder has been renamed tomcp_server. This change ensures that the server package and map package can coexist without import errors.The new pipeline was completed successfully.